Исправил срабатывание focus() для undefined #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GulomovCreative Посмотри, пожалуйста, как время будет. Я вроде все протестил, но мало ли... |
Ruslan-Aleev
force-pushed
the
fix-clientconfig
branch
from
eff41fc to
85d3b00
Compare
Ruslan-Aleev
force-pushed
the
fix-clientconfig
branch
from
85d3b00 to
bbfa3a8
Compare
webinmd
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что оно делает?
В Ace, если других полей нету в форме, то
this.editor.focus();не срабатывал, т.к.this.editorвозвращал undefined.Поменял на
(this.editor || this.valueHolder).focus();проблема пропала. По логике, решение универсальное и чинит баг, проблем быть не должно.Для теста нужно в ClientConfig создать Ace-настройку и расположить ее первой (или единственной) в группе, тогда раздел ClientConfig падает с ошибкой в консоли:
После фикса все норм:
Связанные проблема(ы)/PR(ы)
modmore/ClientConfig#180